Feature entry correction - #51
Merged
Merged
Conversation
Cleaned the NAMESPACE, re-ran devtools::document(), and added a missing string after a @return to satisfying the documentation check.
epbrenner
previously approved these changes
Sep 14, 2026
epbrenner
left a comment
epbrenner
left a comment
Contributor
There was a problem hiding this comment.
Preparing genomes through ML modeling runs as expected with the fix. Cleaned the NAMESPACE to reflect the feature_to_cluster.R file being dropped since devtools::install(".") failed without that, but it's ready to merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Pfam entries had a mismatch in how they are processed. eg,
Beta-lactamaseandBeta.lactamaseFor uniform processing, I chose to convert all
-to.While making the changes to
feature_to_head.R, I also removed the now obsoletefeature_to_cluster.R